[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [Xen-devel] [PATCH 00 of 20] NestedVMX support
> -----Original Message----- > From: Tim Deegan [mailto:Tim.Deegan@xxxxxxxxxx] > Sent: Thursday, June 02, 2011 10:34 PM > To: Dong, Eddie > Cc: xen-devel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [Xen-devel] [PATCH 00 of 20] NestedVMX support> > Hi, > > Thanks for these patches. They look pretty good; I have a few comments > on the individual patches that I'll post separately. > > Overall the only worry I have is the number of TODOs left at the end of > the series. Some of them are obvioulsy ony important when you come to > do the nested EPT work. I'd appreciate a comment on whether you think > any of these is important: > > +static int nvmx_intr_intercept(struct vcpu *v, struct hvm_intack > intack) > +{ > + u32 exit_ctrl; > + > + /* > + * TODO: > + * - if L1 intr-window exiting == 0 > + * - vNMI > + */ > Deleted. > > +static int decode_vmx_inst(struct cpu_user_regs *regs, > + struct vmx_inst_decoded *decode, > + unsigned long *poperandS, int > vmxon_check) > +{ > [...] > + /* TODO: segment type check */ > Fixed. > This one, at least, I think does need to be fixed! > > > +static void load_shadow_control(struct vcpu *v) > +{ > + /* TODO: Make sure the shadow control doesn't set the bits > + * L0 VMM doesn't handle. > + */ > deleted > > +int nvmx_handle_vmlaunch(struct cpu_user_regs *regs) > +{ > + /* TODO: check for initial launch/resume */ > + return nvmx_handle_vmresume(regs); > +} > Handled w/ correct launch state. > > +void nvmx_idtv_handling(void) > +{ > [...] > + /* TODO: NMI */ > +} > deleted > > +static void load_shadow_guest_state(struct vcpu *v) > +{ > [...] > + /* XXX: should refer to GUEST_HOST_MASK of both L0 and L1 */ > Deleted and will revisit later. > > Cheers, > > Tim. > > -- > Tim Deegan <Tim.Deegan@xxxxxxxxxx> > Principal Software Engineer, Xen Platform Team > Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |