Re: [Xen-devel] Re: [RFC PATCH] set current_state to D0 in register_slot

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

Jesse,
do you have any comments on the following patch?
Also, are you OK with taking "set current_state to D0 in register_slot"
in your tree? Otherwise should I send a pull request to Linus with the
patch and your ack?
Cheers,

Stefano

On Tue, 8 Mar 2011, Ian Campbell wrote:
> From 5cb5d576e7177762abe29cfba3f616c48e619145 Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Date: Tue, 8 Mar 2011 16:16:34 +0000
> Subject: [PATCH] acpiphp: assume device is in state D0 after powering on a 
> slot.
> 
> Devices which do not support PCI configuration space based power
> management may not otherwise be enabled.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  drivers/pci/hotplug/acpiphp_glue.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/acpiphp_glue.c 
> b/drivers/pci/hotplug/acpiphp_glue.c
> index e610cfe..a502fef 100644
> --- a/drivers/pci/hotplug/acpiphp_glue.c
> +++ b/drivers/pci/hotplug/acpiphp_glue.c
> @@ -827,6 +827,13 @@ static int __ref enable_device(struct acpiphp_slot *slot)
>       acpiphp_set_hpp_values(bus);
>       acpiphp_set_acpi_region(slot);
>       pci_enable_bridges(bus);
> +
> +     list_for_each_entry(dev, &bus->devices, bus_list) {
> +             /* Assume that newly added devices are powered on already. */
> +             if (!dev->is_added)
> +                     dev->current_state = PCI_D0;
> +     }
> +
>       pci_bus_add_devices(bus);
>  
>       list_for_each_entry(func, &slot->funcs, sibling) {
> -- 
> 1.5.6.5
> 
> 
> 
> -- 
> Ian Campbell
> Current Noise: Behemoth - Daimonos
> 
> Unix is a Registered Bell of AT&T Trademark Laboratories.
>               -- Donn Seeley
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel