Re: [Xen-devel] xen boot crash

[Keir Fraser <keir@xxxxxxx>]

On 12/01/2011 10:09, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> On 12.01.11 at 10:45, Christoph Egger <Christoph.Egger@xxxxxxx> wrote:
>> Changeset 22706:ca10302ac285  causes below boot crash.
>> Reverting it makes xen boot again.
>> 
>> The rip points to xen/common/page_alloc.c:543
> 
> Assuming the change was tested on x86-64, it must be something
> unusual on your system that results in free_heap_pages() getting
> called before the compat m2p table (and possibly the native one
> too, as that one gets written after the compat one) was set up.
> For understanding that, the actual call stack would need to be
> worked out from the raw stack dump you provided.
> 
> Perhaps we'll need a global variable indicating when those tables
> are ready to be used...

I'll revert the patch for now, I think we'll need to revisit after 4.1.0.
Not really an issue I'd say as it's pretty clear that xenpaging is not going
to be in a production-ready state for 4.1.0 anyway. Best we can hope for is
to get some tested patches backported for 4.1.1 or 4.1.2.

The basic issue here seems to be a dependency violation in trying to access
m2p at all from the heap allocator. The code that sets up the m2p itself
allocs from the domheap, so having the heap, or domheap, subsystem, address
the m2p itself seems flawed. We'd get away with it from free_domheap_pages()
as no pages get freed until later, as it happens, but: (a) not nice to
depend on that; (b) it's nice to do it in free_heap_pages() and cover
Xenheap as well as domheap.

One way around this might be to set up the m2p tables earlier, perhaps when
we currently init_frametable(), and get the required pages via
alloc_bootheap_pages(). But this is too big a change for 4.1 now.

 -- Keir

> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel