[Xen-devel] RE: [RFC][PATCH][VTD][v4] consolidate VT-d quirks into a single file quirks.c

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 28.10.10 at 17:50, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
>> The non-void return value of cantiga_vtd_ops_preamble() also
>> looks bogus, btw.
> 
> The return value is not important in this case.  It is the requirement of 
> the errata workaround to read the MMIO register.

Hmm, yes, but this could be expressed differently, as a non-void
return generally implies there's at least on caller wanting to look
at the value returned.

Anyway, looks good to me now. Thanks!

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel