[Xen-devel] RE: [RFC][PATCH][VTD][v3] consolidate VT-d quirks into a single file quirks.c

["Kay, Allen M" <allen.m.kay@xxxxxxxxx>]

Jan, sorry disappearing for the last week.  I had to attend to some urgent 
matters.

> The issue is not with doing a mapping, but with where (in virtual address 
> space)
> you map to: You're passing a *physical* address for what is to be a *virtual* 
> one
> (first argument to map_pages_to_xen()), i.e. as soon as there is any domain 
> the
> mapping will conflict with the domain's use of virtual addresses.

Agree.  I fixed it in the attached v3 patch by using a fixmap entry for doing 
ioremap.

> There's one more thing I just noticed: Isn't warning you're
> adding to is_igd_drhd() going to trigger needlessly (and perhaps
> frequently) on Intel IOMMU systems without any device at 0:2.0
> I think if at all, the warning should only be issued once.

I removed the warning message.

Allen

Attachment: quirks10272.patch
Description: quirks10272.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel