Re: [Xen-devel] [PATCH 1 of 3] xenpaging: Add a check to Xen for EPT

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Patrick Colp writes ("Re: [Xen-devel] [PATCH 1 of 3] xenpaging: Add a check to 
Xen for EPT"):
> ENOSYS tends to be used to indicate an invalid/unsupported domctl. I
> chose ENODEV as an alternative so that it provides a unique error
> return code and seemed relatively sane (vs say something like E2BIG).
> I'm not particularly fussed about what the actually error code is, I
> just wanted it to be able to distinguish a lack-of-EPT-support error
> from other errors (the other error codes in use in the mem-event
> enable domctl are ENOSYS and EINVAL). If you have a suggestion for
> another one to use, I'm happy to hear it.

No, thanks, your rationale makes sense to me.  ENODEV is fine.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel