Re: [Xen-devel] Re: [Xen-users] Re: Xen 4.0 on gentoo hotplug scripts problem? broken with filenames with spaces

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Fri, Apr 09, 2010 at 01:33:30PM +0300, Pasi Kärkkäinen wrote:
> On Fri, Apr 09, 2010 at 11:28:51AM +0100, Andrew Lyon wrote:
> > On Fri, Apr 9, 2010 at 9:21 AM, Andrew Lyon <andrew.lyon@xxxxxxxxx> wrote:
> > > On Fri, Apr 9, 2010 at 9:15 AM, Andrew Lyon <andrew.lyon@xxxxxxxxx> wrote:
> > >> On Fri, Apr 9, 2010 at 9:10 AM, Pasi Kärkkäinen <pasik@xxxxxx> wrote:
> > >>> On Fri, Apr 09, 2010 at 08:45:44AM +0100, Andrew Lyon wrote:
> > >>>> On Thu, Apr 8, 2010 at 10:20 PM, Pasi Kärkkäinen <pasik@xxxxxx> wrote:
> > >>>> > On Thu, Apr 08, 2010 at 02:14:17PM -0700, Boris Derzhavets wrote:
> > >>>> >>    I believe profile should look like
> > >>>> >>
> > >>>> >>    memory=512
> > >>>> >>    name='Gentoo-32-test'
> > >>>> >>    vif=['bridge=eth(x)']
> > >>>> >>    bootloader='/usr/bin/pygrub'
> > >>>> >>    disk=['file:/mnt/tb1_store/Xen
> > >>>> >>    VMs/Gentoo-32/Gentoo-32.sda1,xvda,w','phy:/dev/test/test,xvdb 
> > >>>> >> ,w']
> > >>>> >>    extra='gentoo=nodevfs console=xvc0'
> > >>>> >>
> > >>>> >>    It's PV domU , so xvda,xvda,.....
> > >>>> >>
> > >>>> >>    Blktap driver is not important, no "tap:aio"
> > >>>> >>
> > >>>> >
> > >>>> > Also I think Xen 4.0.0 needs to have "disk = [ 
> > >>>> > "tap:tapdisk:aio:/path/images/disk.img,xvda,w" ]" to use blktap2.
> > >>>>
> > >>>> I tried that syntax but it does not work:
> > >>>>
> > >>>> name='Gentoo-32-test'
> > >>>> vif=['bridge=eth0']
> > >>>> bootloader='/usr/bin/pygrub'
> > >>>> disk=[ "tap:tapdisk:aio:/mnt/tb1_store/Xen 
> > >>>> VMs/Gentoo-32/Gentoo-32.sda1,xvda,w"]
> > >>>> extra='gentoo=nodevfs console=xvc0'
> > >>>>
> > >>>> Using config file "./Gentoo-32-test.cfg".
> > >>>> Error: [Errno 2] No such file or directory: 'aio:/mnt/tb1_store/Xen
> > >>>> VMs/Gentoo-32/Gentoo-32.sda1'
> > >>>>
> > >>>
> > >>> Hmm.. that's weird. The blktap2 syntax is correct based on the latest 
> > >>> blktap2 README here:
> > >>> http://lxr.xensource.com/lxr/source/tools/blktap2/README
> > >>>
> > >>>> I changed the config back to file:/ and tried again, the xm create
> > >>>> process seemed to hang and the block script was stuck:
> > >>>>
> > >>>
> > >>> Ok, so you have some general problem, not really blktap2 related..
> > >>>
> > >>>>
> > >>>> root     14152  0.0  0.0  17596  1572 ?        S<   08:43   0:00
> > >>>> /bin/bash /etc/xen/scripts/block add
> > >>>>
> > >>>> eventually it errors  Error: Device 51712 (vbd) could not be
> > >>>> connected. /etc/xen/scripts/block failed; error detected.
> > >>>>
> > >>>> And the remove script is also stuck:
> > >>>>
> > >>>> /bin/bash /etc/xen/scripts/block remove
> > >>>>
> > >>>
> > >>> Did you install Xen 4.0.0 over some old version?
> > >>>
> > >>> Did you remove the old version first? Maybe your 4.0.0 is not 
> > >>> completely/properly installed..
> > >>
> > >> I will try removing Xen first, including all of /etc/xen/
> > >>
> > >> Andy
> > >>
> > >>>
> > >>> Pasi
> > >>>
> > >>>
> > >>
> > >
> > > I think you are onto something, after completely removing Xen I cannot
> > > compile 4.0:
> > >
> > > Wl,-O1          -L../../tools/libxc -lxenctrl    -L../../tools/libxc
> > > -lxenctrl          -o libvhd.so.1.0.0 -luuid libvhd.o libvhd-journal.o
> > > vhd-util-coalesce.o vhd-util-create.o vhd-util-fill.o
> > > vhd-util-modify.o vhd-util-query.o vhd-util-read.o vhd-util-repair.o
> > > vhd-util-resize.o vhd-util-revert.o vhd-util-set-field.o
> > > vhd-util-snapshot.o vhd-util-scan.o vhd-util-check.o relative-path.o
> > > atomicio.o ../../lvm/lvm-util.o
> > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.4/../../../../x86_64-pc-linux-gnu/bin/ld:
> > > cannot find -lxenctrl
> > > collect2: ld returned 1 exit status
> > > make[6]: *** [libvhd.a] Error 1
> > > make[6]: Leaving directory
> > > `/var/tmp/portage/app-emulation/xen-tools-4.0.0/work/xen-4.0.0/tools/blktap2/vhd/lib'
> > > make[5]: *** [subdir-all-lib] Error 2
> > >
> > > Which makes me think that some part of 4.0 was compiled against 3.4.2...
> > >
> > > Andy
> > >
> > 
> > I've found at least one problem with 4.0, if the path to the disk
> > backing file contains any spaces then the hotplug scripts stall and
> > domain creation fails, I had made a symlink without spaces but
> > apparently the scripts attempt to resolve symlinks so I had to
> > physically rename the dir so that no spaces are used.
> > 
> > I struggled to find any errors relating to domain creation, but the
> > hotplug cleanup scripts do log some errors:
> > 
> > /etc/xen/scripts/xen-hotplug-cleanup: line 25: [: !=: unary operator 
> > expected
> > stat: cannot stat `/mnt/tb1_store/Xen': No such file or directory
> > stat: cannot stat `VMs/WinXP/WinXP.hda': No such file or directory
> > xenstore-read: couldn't read path backend/vbd/7/768/node
> > 
> > The path was "/mnt/tb1_store/Xen VMs/WinXP/WinXP.hda" and worked fine with 
> > 3.4.2
> > 
> 
> Thanks for looking into that.
> I added xen-devel to CC.. maybe this rings some bells for someone.
> 

Hello,

This has been fixed by:
http://xenbits.xen.org/xen-4.0-testing.hg?rev/72b9c78aef6b

So upcoming Xen 4.0.1 should work OK with spaces in vbd filanames.

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel