[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] support cpupool for xl create

  • To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Tue, 11 May 2010 07:47:59 +0200
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 10 May 2010 22:48:59 -0700
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=vl3p04rPv1soP8Nonz8VlY2TghdRpMtpiy25pyW70vKs+AQNlin03O0z siXL3VGM4WewhyVk4Lc/WUYuyt80CbZiY5UYFAPxwnDIu5godxM2Ta7Dm NRPRo343X3PK8jNKxEi5wvvFgBhk+rTaepTHCT0ZgEcfFhRf4SkrUcd3y 7qfa0ixbkYZutZYwC+I0jMfXLup4UIFFZ7X4FoDuTkl9G76bt6jmT4aCo EI8mZ/9xeaZ/xN3ilxTT1327IWZOh;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 05/10/2010 10:07 PM, Jeremy Fitzhardinge wrote:
On 05/09/2010 11:58 PM, Juergen Gross wrote:
On 05/10/2010 08:42 AM, Jeremy Fitzhardinge wrote:
On 05/09/2010 11:05 PM, Juergen Gross wrote:
diff -r bbf009817ffb tools/libxl/libxl.c
--- a/tools/libxl/libxl.c    Fri May 07 19:22:28 2010 +0100
+++ b/tools/libxl/libxl.c    Fri May 07 14:57:00 2010 -0700
@@ -169,7 +169,8 @@

        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/uuid", vm_path),
uuid_string, strlen(uuid_string));
        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/name", vm_path),
info->name, strlen(info->name));
-    xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name",
vm_path), info->poolname, strlen(info->poolname));
+    if (info->poolname)
+        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name",
vm_path), info->poolname, strlen(info->poolname));

        libxl_xs_writev(ctx, t, dom_path, info->xsdata);
        libxl_xs_writev(ctx, t, libxl_sprintf(ctx, "%s/platform",
dom_path), info->platformdata);

fixes it for me.

You seem to have specified a not existing cpupool.
The solution should not be to ignore this, but to do a proper test
on the
pool parameter.
Attached patch does this.

I'm not using cpupools.  My config makes no mention of "pool" at all.

I tested this case and it worked for me.

Perhaps one thing that you're not testing: I'm using oxenstored, and I'm
xl without ever having started xend, so xenstore starts out completely
empty.  I don't know if that makes a difference.

It does :-)
Without proper xenstore entries it is impossible to get a cpupool name from
it's id. Id 0 is hard wired to "Pool-0", so this case can be handled even
without xenstore.
I modified the patch accordingly.


Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Attachment: libxl-poolerr.patch
Description: Text Data

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.