[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] support cpupool for xl create

  • To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Mon, 10 May 2010 08:05:32 +0200
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Sun, 09 May 2010 23:06:16 -0700
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=GFkKh7kTcWtvbAdtPKV3m9yU6fqUo7nCkBsnrwZwS/f+f5g8GU7hebz/ 7i7qmDubzmFrWl/677SCntHtD1uBN2Es3yOTUKon+hj9QPPT7vxFjNqSo HmE/TrKgkZrOx8XTTDj5G/3cNwK3ZTFBku4pR5yExwcOLZjPGLfH5/XE2 wfnPj5tnMOlBhUZqjP5CVQsv4PPVIz06gsFUKRofxUdClNBvYRbSpDu/2 MpmxZBAeI5AnEWTirRXQEXt7xxrG7;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 05/07/2010 11:57 PM, Jeremy Fitzhardinge wrote:
On 05/07/2010 01:14 AM, Juergen Gross wrote:

attached patch supports cpupool specification for xl create.

This crashes for me:

(gdb) run create /etc/xen/f13pv64
Starting program: /usr/sbin/xl create /etc/xen/f13pv64
[Thread debugging using libthread_db enabled]
Parsing config file /etc/xen/f13pv64

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff79cd805 in libxl_domain_make (ctx=0x60f8a0, info=0x7fffffffe0b0,
     domid=0x60f890) at libxl.c:172
172         xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), 
info->poolname, strlen(info->poolname));
(gdb) p info->poolname
$2 = 0x0


diff -r bbf009817ffb tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Fri May 07 19:22:28 2010 +0100
+++ b/tools/libxl/libxl.c       Fri May 07 14:57:00 2010 -0700
@@ -169,7 +169,8 @@

      xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/uuid", vm_path), 
uuid_string, strlen(uuid_string));
      xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/name", vm_path), info->name, 
-    xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), 
info->poolname, strlen(info->poolname));
+    if (info->poolname)
+        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name", vm_path), 
info->poolname, strlen(info->poolname));

      libxl_xs_writev(ctx, t, dom_path, info->xsdata);
      libxl_xs_writev(ctx, t, libxl_sprintf(ctx, "%s/platform", dom_path), 

fixes it for me.

You seem to have specified a not existing cpupool.
The solution should not be to ignore this, but to do a proper test on the
pool parameter.
Attached patch does this.


Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Attachment: libxl-poolerr.patch
Description: Text Data

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.