Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in append mode

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Yosuke Iwamatsu writes ("Re: [Xen-devel] [PATCH] xend: open qemu-dm log files 
in append mode"):
> So the attached patch improves the qemu-log rotation in xend to keep
> maximum of 20 backup logfiles per domain. I still prefer the previous
> patch that will avoid information loss when, for example, a guest
> repeats cursh and reboot. But this patch might be at least a little bit
> better than the current one-historic-backup solution. Any comment?

I think this patch is much better.

It would be good if the maximum logfiles to keep would be
configurable; making it part of the ordinary xend configuration would
do.

Also, one minor stylistic point.  This idiom
    if os.path.exists(self.logfile + ".%d" % nr_max_log_rotation):
is rather unusual, although not actually wrong.  It combines string
concatenation and %-formatting.  Surely one of
    "%s.%d" % (self.logfile, nr_max_log_rotation)
    self.logfile + '.' + `nr_max_log_rotation`
would be better ?  (I would have used the former.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel