Re: [Xen-devel][PATCH] qemu: Send unit_attention on cd-rom not_ready to ready transition

[Pat Campbell <plc@xxxxxxxxxx>]

Ian Jackson wrote:
> Pat Campbell writes ("[Xen-devel][PATCH] qemu: Send unit_attention on cd-rom 
> not_ready to ready transition"):
>   
>> Patch sends a UNIT_ATTENTION(6), MEDIUM_MAY_HAVE_CHANGED(0x28) sense
>> when cdrom transitions from not ready to ready. 
>>     
>
> It seems to me that this patch should go upstream to qemu.
> Is there some reason why not ?
>   
Submitted upstream to qemu this morning.
> If it should, please prepare a version of it against qemu CVS head and
> submit it to the qemu list (qemu-devel@xxxxxxxxxx).  I'll keep an eye
> on it there too, as the qemu guys are quite busy and have a tendency
> to overlook things so a reminder can be necessary.
>
> in general it would be helpful if contributors helped keep to a
> minimum the non-Xen-specific changes to ioemu.  For larger patches
> which need to vary substantially because of the existing differences
> between upstream and ioemu, it's probably easier for someone who knows
> those differences (eg, me) to do this.  But I think that at least for
> a small independent change like this it would be good for patch
> submitters to talk to upstream as well as us.
>
> I haven't double-checked the ATA spec but your patch looks reasonable
> for xen-unstable, anyway.
>
> Thanks,
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>   


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel