Re: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-11-07 at 11:29 +0800, Han, Weidong wrote:
> This patch corrects PCI_EXP_DEVCTL_FLR so that function level reset will
> be really executed, and also replaces some magic numbers with micro.

   PAGE_SHIFT/SIZE/MASK shouldn't be used in userspace so freely.
AFAICT, this breaks the build on x86_64 and ia64.  Ideally we should use
getpagesize().  If that doesn't work, at least define them to the
defaults locally like in toosl/ioemu/hw/iommu.c.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel