[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR



I've no idea where the value 0x1b came from, but bit 15 is the FLR bit in
the DEVCTL register, according to the PCI Express spec. So the patch looks
good.

 -- Keir

On 7/11/07 08:53, "Guy Zana" <guy@xxxxxxxxxxxx> wrote:

> -#define PCI_EXP_DEVCTL_FLR      (0x1b)
> +#define PCI_EXP_DEVCTL_FLR      (1 << 15)
> 
> Can you please explain what is the difference (in functionality) between these
> values?
> 
> Thanks,
> Guy.
> 
>> -----Original Message-----
>> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of
>> Han, Weidong
>> Sent: Wednesday, November 07, 2007 5:30 AM
>> To: xen-devel@xxxxxxxxxxxxxxxxxxx
>> Cc: Kay, Allen M
>> Subject: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR
>> 
>> This patch corrects PCI_EXP_DEVCTL_FLR so that function level
>> reset will be really executed, and also replaces some magic
>> numbers with micro.
>> 
>> Signed-off-by: Anthony Xu <anthony.xu@xxxxxxxxx>
>> Signed-off-by: Weidong Han <weidong.han@xxxxxxxxx>
>> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.