Re: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile

["Amitabha Roy" <amitabha.roy@xxxxxxxxx>]

Forgot to mention, the CONFIG_FRAME_POINTER is needed by the
backtrace.c file I pulled from linux.

On 6/7/07, Amitabha Roy <amitabha.roy@xxxxxxxxx> wrote:
> I've moved the frame pointer code into the xen specific makefile.
> I've also fixed the per file inconsistencies. I noticed that some
> files already have a few inconsistencies within themselves in places
> other than my code.
>
> Perhaps you could accept this patch and I can send a separate one
> later fixing those ?
> One of the suggestions I had from Renato was to minimize any diffs of
> files based off linux versions so that pulling in updates will be
> easier. So I can look into those on a case by case basis with him.
>
> -Amitabha
>
>
> On 6/7/07, Keir Fraser <keir@xxxxxxxxxxxxx> wrote:
> > On 7/6/07 10:20, "Amitabha Roy" <amitabha.roy@xxxxxxxxx> wrote:
> >
> > > Coding style is likely because I've preserved the formatting of the
> > > original files (esp. of backtrace.c from Linux for simple diffs).
> > > There isnt a consistent style across the files that I could follow.
> >
> > Linux-derived files follow Linux style (this will apply to many of the files
> > under arch/x86/oprofile). Xen-specific files follow Xen style as in e.g.,
> > page_alloc.c, xmalloc.c, xenoprof.c).
> >
> > If any of the files you edit don't follow this, please fix them first, and
> > send a separate patch as a prerequisite for your own.
> >
> > > CONFIG_FRAME_POINTER gets used in config/StdGNU.mk.
> > > I simply followed whatever was done for XEN_TARGET_X86_PAE. However
> > > unlike the PAE case I haven't ensured that frame pointers are turned
> > > on both in the kernel and Xen. If you want I can move all the frame
> > > pointer related stuff into xen/Rules.mk.
> >
> > Yes, please. Call the option frame_pointer, in line with other Xen-specific
> > options which are also lower case.
> >
> >  -- Keir
> >
> >
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel