Re: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile

["Amitabha Roy" <amitabha.roy@xxxxxxxxx>]

Hi Keir

Coding style is likely because I've preserved the formatting of the
original files (esp. of backtrace.c from Linux for simple diffs).
There isnt a consistent style across the files that I could follow.

CONFIG_FRAME_POINTER gets used in config/StdGNU.mk.
I simply followed whatever was done for XEN_TARGET_X86_PAE. However
unlike the PAE case I haven't ensured that frame pointers are turned
on both in the kernel and Xen. If you want I can move all the frame
pointer related stuff into xen/Rules.mk.

-Amitabha


On 6/7/07, Keir Fraser <keir@xxxxxxxxxxxxx> wrote:
> On 7/6/07 04:34, "Amitabha Roy" <amitabha.roy@xxxxxxxxx> wrote:
>
> > This patch implements backtrace support in Xenoprofile. It's been
> > reviewed by Renato. I've tested it out successfully on xen x86_32 and
> > x86_64. I've added stubs for the backtrace for ia64 to ensure that it
> > compiles ok but havent been able to test that out. However, I believe
> > there shouldn't be any problems.
>
> Coding style is all over the shop. Where does CONFIG_FRAME_POINTER get used?
> I'm not sure that FRAME_POINTER needs to be a top-level option -- it's only
> necessary for Xen build isn't it?
>
>  -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel