[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile


  • To: Amitabha Roy <amitabha.roy@xxxxxxxxx>, Xen developers mailing list <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Thu, 07 Jun 2007 10:01:45 +0100
  • Cc: "Santos, Jose Renato G" <joserenato.santos@xxxxxx>
  • Delivery-date: Thu, 07 Jun 2007 02:00:00 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Aceo4nkIt7I72hTVEdyfYQAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile

On 7/6/07 04:34, "Amitabha Roy" <amitabha.roy@xxxxxxxxx> wrote:

> This patch implements backtrace support in Xenoprofile. It's been
> reviewed by Renato. I've tested it out successfully on xen x86_32 and
> x86_64. I've added stubs for the backtrace for ia64 to ensure that it
> compiles ok but havent been able to test that out. However, I believe
> there shouldn't be any problems.

Coding style is all over the shop. Where does CONFIG_FRAME_POINTER get used?
I'm not sure that FRAME_POINTER needs to be a top-level option -- it's only
necessary for Xen build isn't it?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.