RE: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough (non-IOMMU)

["Guy Zana" <guy@xxxxxxxxxxxx>]

> -----Original Message-----
> From: Muli Ben-Yehuda [mailto:muli@xxxxxxxxxx] 
> Sent: Monday, June 04, 2007 9:28 PM
> To: Guy Zana
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough 
> (non-IOMMU)
> 
> > +
> > +#ifdef CONFIG_NEO
> > +    p->eip = regs->eip;
> > +    p->cs = regs->cs;
> > +#endif
> 
> For merging it would be good if the CONFIG_XXX bits could go 
> away unless absolutely necessary.

Ok.

> 
> >      p->io_count++;
> >  
> > --- a/xen/include/asm-x86/e820.h    Sat May 05 13:48:05 2007 +0100
> > +++ b/xen/include/asm-x86/e820.h    Thu May 31 21:04:53 2007 +0300
> > @@ -3,13 +3,6 @@
> >  
> >  #include <public/hvm/e820.h>
> >  
> > -#define E820MAX    128
> > -
> > -struct e820map {
> > -    int nr_map;
> > -    struct e820entry map[E820MAX];
> > -};
> > -
> 
> Why does this need to move to hvm/e820.h?

It's more logical this way, all e820 structures on the same file.
I don't have the code in front of me but I think I needed struct e820map in 
libxc.

Thanks,
Guy.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel