Re: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough (non-IOMMU)

[Muli Ben-Yehuda <muli@xxxxxxxxxx>]

On Thu, May 31, 2007 at 07:05:01PM -0400, Guy Zana wrote:

> --- a/xen/arch/x86/hvm/platform.c     Sat May 05 13:48:05 2007 +0100
> +++ b/xen/arch/x86/hvm/platform.c     Thu May 31 21:04:53 2007 +0300
> @@ -844,6 +844,9 @@ void send_pio_req(unsigned long port, un
>      struct vcpu *v = current;
>      vcpu_iodata_t *vio;
>      ioreq_t *p;
> +#ifdef CONFIG_NEO
> +    struct cpu_user_regs *regs = &v->arch.hvm_vcpu.io_op.io_context;
> +#endif
>  
>      if ( size == 0 || count == 0 ) {
>          printk("null pio request? port %lx, count %lx, "
> @@ -870,6 +873,11 @@ void send_pio_req(unsigned long port, un
>      p->addr = port;
>      p->count = count;
>      p->df = df;
> +
> +#ifdef CONFIG_NEO
> +    p->eip = regs->eip;
> +    p->cs = regs->cs;
> +#endif

For merging it would be good if the CONFIG_XXX bits could go away
unless absolutely necessary.

>      p->io_count++;
>  
> --- a/xen/include/asm-x86/e820.h      Sat May 05 13:48:05 2007 +0100
> +++ b/xen/include/asm-x86/e820.h      Thu May 31 21:04:53 2007 +0300
> @@ -3,13 +3,6 @@
>  
>  #include <public/hvm/e820.h>
>  
> -#define E820MAX      128
> -
> -struct e820map {
> -    int nr_map;
> -    struct e820entry map[E820MAX];
> -};
> -

Why does this need to move to hvm/e820.h?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel