[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Do not destroy domains that timeout when shutting down

  • To: John Levon <levon@xxxxxxxxxxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Fri, 25 May 2007 15:20:54 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 25 May 2007 07:19:24 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acee1+daJjLJjgrLEdy0gAAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Do not destroy domains that timeout when shutting down

On 25/5/07 15:18, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

>> Do we really need to rename it ? Various bits of code do uniqueness checks
>> on both name & uuid. If we rename it, though uuid checks still work, any such
>> checks on the name will not be correct. IMHO, if shutdown fails we should
>> just
>> leave the guest alone completely. The admin knows that they requested a
>> shutdown,
>> and can clearly see that after 'n' seconds it is still around & can take the
>> appropriate action - admins already know to watch for failed shutdowns since
>> this stuff happens on bare metal too. Renaming to 'report' error just seems
>> wrong to me & will potentially confuse tools.
> Seems like a reasonable argument to me... Keir?

I'm not too fussed either way really.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.