Re: [Xen-devel] [PATCH] Do not destroy domains that timeout when shutting down

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Fri, May 25, 2007 at 02:09:23PM +0100, Daniel P. Berrange wrote:

> > Instead of violently destroying a domain that is not responding to a 
> > shutdown
> > request, rename the domain to indicate the problem and leave it alone; this
> > allows the admin to make corrective actions (which may or may not include
> > destroying the domain).
> 
> Do we really need to rename it ? Various bits of code do uniqueness checks
> on both name & uuid. If we rename it, though uuid checks still work, any such 
> checks on the name will not be correct. IMHO, if shutdown fails we should just
> leave the guest alone completely. The admin knows that they requested a 
> shutdown,
> and can clearly see that after 'n' seconds it is still around & can take the
> appropriate action - admins already know to watch for failed shutdowns since
> this stuff happens on bare metal too. Renaming to 'report' error just seems
> wrong to me & will potentially confuse tools.

Seems like a reasonable argument to me... Keir?

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel