[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH][XEND]Fix checkname so that it detects duplicate domains.

  • To: "Petersson, Mats" <Mats.Petersson@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Fri, 25 May 2007 10:39:37 +0100
  • Delivery-date: Fri, 25 May 2007 02:38:08 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Aced6etScrTUhsnqQ+CeH6LEai4TSAAxBT/bAAAPFeAAAJfPkw==
  • Thread-topic: [Xen-devel] [PATCH][XEND]Fix checkname so that it detects duplicate domains.

On 25/5/07 10:25, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote:

>> If we don't enforce UUID uniqueness, what is the point of
>> having a UUID?
>> Also, don't we store some VM information in /vm/<uuid> in
>> xenstore: how does
>> that work out if we have multiple domains with the same UUID?
> All very good points. I don't actually know how this is meant to work,
> I'm just fixing an apparent bug, which is that if the UUID is
> duplicated, you can have two domains with the same name, which isn't
> what is supposed to happen. There should probably ALSO be a "_checkuuid"
> function to verify that the UUID is unique. Not sure it's my place to
> fix that, tho'?

Oh. Your patch comment strongly implies that the current behaviour of xend
is to check for UUID uniqueness, and that you are changing this to a check
for name uniqueness. And that looks like what this patch does, too.

But here you seem to be saying that xend enforces neither UUID uniqueness
nor name uniqueness?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.