[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH][XEND]Fix checkname so that it detects duplicate domains.

  • To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "Petersson, Mats" <Mats.Petersson@xxxxxxx>
  • Date: Fri, 25 May 2007 11:25:22 +0200
  • Delivery-date: Fri, 25 May 2007 02:23:51 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Aced6etScrTUhsnqQ+CeH6LEai4TSAAxBT/bAAAPFeA=
  • Thread-topic: [Xen-devel] [PATCH][XEND]Fix checkname so that it detects duplicate domains.


> -----Original Message-----
> From: Keir Fraser [mailto:keir@xxxxxxxxxxxxx] 
> Sent: 25 May 2007 10:21
> To: Petersson, Mats; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH][XEND]Fix checkname so that 
> it detects duplicate domains.
> On 24/5/07 10:57, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote:
> > The previous behaviour was to check that the UUID is 
> different, but for
> > domains that either have UUID in the config file, or that 
> are the result
> > of restore, the UUID is definitely going to be the same for multiple
> > instances, so I believe this isn't a correct behaviour in the first
> > place. 
> If we don't enforce UUID uniqueness, what is the point of 
> having a UUID?
> Also, don't we store some VM information in /vm/<uuid> in 
> xenstore: how does
> that work out if we have multiple domains with the same UUID?

All very good points. I don't actually know how this is meant to work,
I'm just fixing an apparent bug, which is that if the UUID is
duplicated, you can have two domains with the same name, which isn't
what is supposed to happen. There should probably ALSO be a "_checkuuid"
function to verify that the UUID is unique. Not sure it's my place to
fix that, tho'?

I still think my fix is valid, although, of course, if the UUID is
always guaranteed to be unique even during save/restore/migration within
the same machine, then we could of course use the UUID instead of the

>  -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.