[Xen-devel] [PATCH] Add syntax checking for xm block-attach

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi,

Currently, xm block-attach command doesn't have syntax checking 
about the mode('r' or 'w').  Even if wrong characters to the 
mode are specified, VBD is attached to VM with the read-only 
mode.

# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769  
# xm block-attach vm1 phy:ram2 hdb1 xyz
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769  
833    0    0     4      8      585   /local/domain/0/backend/vbd/2/833  


This patch adds syntax checking for xm block-attach command.

# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769  
# xm block-attach vm1 phy:ram2 hdb1 xyz
Error: Invalid mode
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769  


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Attachment: block-attach.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel