[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] X86_64 "assert" when booting 64-bit image.

Keir Fraser wrote:
> On 9 Feb 2006, at 17:44, Nakajima, Jun wrote:
>> I think that particular check is valid; it's basically saying "we
>> shadow page tables only". I feel mfn_is_page_table can be wrong with
>> the type PGT_fl1_shadow, which is bigger than PGT_l4_shadow.  Let me
>> check and come back. I slightly remember I needed to kill the check
>> when I was debugging the code, but not sure if it was triggered by a
>> bug. 
> Yeah, you killed the check by calling ___shadow_status() directly in
> one place, but there's also a path via sync_all which still was bad.
> I just killed the whole function and renamed ___shadow_status() to
> take its place.
>   -- Keir

Sounds sensible. That check was overkill for the non-debug Xen. I
checked if we can remove the whole section, and it worked fine (i.e.
64-bit hvm guest on the 64-bit Xen).

Intel Open Source Technology Center

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.