[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] GNTTABOP_unmap_grant_ref

  • To: "Muli Ben-Yehuda" <mulix@xxxxxxxxx>, "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "King, Steven R" <steven.r.king@xxxxxxxxx>
  • Date: Tue, 24 Jan 2006 17:33:08 -0800
  • Delivery-date: Wed, 25 Jan 2006 01:41:49 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcYhQO6nIifwd5r7Q9GPRa1VXfAWywACkuDA
  • Thread-topic: [Xen-devel] GNTTABOP_unmap_grant_ref

Vma->close() didn't work.  Thanks for the great suggestion though.  :^)

To verify that I wasn't making some new mistake, inspection of
linux/mm/mmap.c shows that Linux calls vma->close() *after* the page
table manipulation.  In do_munmap(), the sequence is:

unmap_region()       <--- page table manipulation buried in here
remove_vma_list()    <--- vma->close() buried in here

Is this turning into a Xen problem?  Why does Xen forbid implicit
unmapping of shared pages?


-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Muli
Sent: Tuesday, January 24, 2006 3:50 PM
To: King, Steven R
Cc: xen-devel; Mark Williamson
Subject: Re: [Xen-devel] GNTTABOP_unmap_grant_ref

On Tue, Jan 24, 2006 at 03:28:55PM -0800, King, Steven R wrote:

> I have not yet found a way to make the GNTTABOP_unmap_grant_ref() call

> in time to avoid the crash.  The driver release() function is too late

> and there's no hook in struct file_operations to handle unmap 
> explicitly.

Could you hook the vma->close function? ISTR it gets called on unmap. If
this is too fine grained or is not called on every munmap (unmapping of
partial VMAs?), you could clean up all mappings when the file that the
application mmap's is closed.

Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

Xen-devel mailing list

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.