Re: [Xen-devel] [PATCH] Getting and setting SEDF scheduling parameters

[Stephan Diestelhorst <sd386@xxxxxxxxx>]

John L Griffin wrote:

> This patch addresses three problems in the function sedf_adjdom():
>
> 3) The code logic in this function is cryptic, and there is not much 
> documentation on how the scheduling parameters should be used.  The 
> attached patch adds comments to the sedf_adjdom() function, and 
> reorders/rewrites the logic of the SCHED_INFO_PUT handling to make the 
> code more self-documenting.
>  
I know, the main problem is, that there are quite a number of different 
interpretations for some of the values, depending on the others. This 
caused some cryptic code as you point out properly, which I wasn't 
really happy with!
Stephan

> Note that this patch makes strong assumptions about how the scheduling 
> parameters are used.  So, I recommend someone take a really close look at 
> my comments to make sure I've preserved the Xen team's intentions for how 
> the SEDF scheduler works. :-)
> Signed-off-by: jlg@xxxxxxxxxx
>
>  
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel