[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table

On 2 Jan 2006, at 10:16, Keir Fraser wrote:

I like the name 'lapic' rather than 'apic' as it explicitly disambiguates from 'ioapic'. And it's only one more character.

Placing the hvm info definitions in public/io/ioreq.h is not right. It probably needs its own header file. How about a new subdirectory include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h?

Also, does anything in Xen actually use the nr_vcpus variable? There's an accessor function for obtaining its value, but noone calls it, nor can I see any reason someone would want to in the future. There's already a setmaxvcpus dom0_op. Seems the Xen code that reads that part of the hvm_info struct could be removed.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.