[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table

On 1 Jan 2006, at 22:43, Li, Xin B wrote:

Rename VMX option name lapic to apic, and pass it to xen by
Previous we pass it to xen by guest vcpu context ECX register, now we
unify to use hvm_info_table.

Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>

I like the name 'lapic' rather than 'apic' as it explicitly disambiguates from 'ioapic'. And it's only one more character.

Placing the hvm info definitions in public/io/ioreq.h is not right. It probably needs its own header file. How about a new subdirectory include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.