[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH][VT] Fix vnc configure problem for vmx guest


  • To: "Ewan Mellor" <ewan@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Ling, Xiaofeng" <xiaofeng.ling@xxxxxxxxx>
  • Date: Mon, 26 Sep 2005 16:59:31 +0800
  • Delivery-date: Mon, 26 Sep 2005 08:57:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcXCdnOHBEd5ltkIT9uCHH9zMOuqGgAAf09w
  • Thread-topic: [Xen-devel] [PATCH][VT] Fix vnc configure problem for vmx guest


Ewan Mellor <> wrote:
> On Mon, Sep 26, 2005 at 09:51:17AM +0800, Xiaofeng Ling wrote:
> 
>> Yes, moving ImageGandler.create after domain create resolves the
>> problem. but I guess the original purpose of putting
>> ImageHandler.create after domain creating maybe if ImageHanler.ceate
>> fails(some configuration wrong), there'll be no useless domain
>> struct exists. So I seperates the configVNC and put it after the
>> domain creating. 
>> Maybe better way is have a pre-config and post-config?
> 
> Well, if the post-config fails, we still have to be able to clean up,
> so there's no extra effort in cleaning up after ImageHandler.create
> as well.  
> That said, there's no problem having an explicit phase of
> post-configuration that sees the image- and device-configuration
> structures, just as you suggest.  
> 
> If it's working for you now, I'll leave it alone for this week, but
> I'll revisit it later and if it looks neater to have a post-config
> phase, I'll do that.  
ok.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.