Re: [Xen-devel] [PATCH][VT] Fix vnc configure problem for vmx guest

[Ewan Mellor <ewan@xxxxxxxxxxxxx>]

On Mon, Sep 26, 2005 at 09:51:17AM +0800, Xiaofeng Ling wrote:

> Yes, moving ImageGandler.create after domain create resolves the 
> problem. but I guess the original purpose of putting ImageHandler.create 
> after domain creating maybe if ImageHanler.ceate fails(some 
> configuration wrong), there'll be no useless domain struct exists.
> So I seperates the configVNC and put it after the domain creating.
> Maybe better way is have a pre-config and post-config?

Well, if the post-config fails, we still have to be able to clean up, so
there's no extra effort in cleaning up after ImageHandler.create as well.
That said, there's no problem having an explicit phase of post-configuration
that sees the image- and device-configuration structures, just as you suggest.

If it's working for you now, I'll leave it alone for this week, but I'll
revisit it later and if it looks neater to have a post-config phase, I'll do
that.

Thanks for all your help,

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel