[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Fix blatant non-archdep'isms... need help with build env change?




On 13 Sep 2005, at 00:25, Magenheimer, Dan (HP Labs Fort Collins) wrote:

If someone more experienced with the build
environment can add an "asm" link (such as
the one created by linux for include/asm),
I would be happy to provide a patch for the
actual changes.

There's already a symlink include/asm-xen/asm pointing to the appropriate arch-specific subdir under asm-xen. Or do you mean something else?

The problem files (in sparse/include/asm-xen):

- synch_bitops.h: explicitly includes
  asm-i386/synch_bitops.h, should include
  <asm-xen/asm/synch_bitops.h>

I can fix this one easily enough.

- hypervisor.h: about half of this header is
  generic and half is x86-specific.  Should
  include <asm-xen/asm/hypervisor.h> for
  arch-dep code.

Approximately none of it looks arch-independent. I'd be happy to move the whole lot to asm-xen/asm-i386 and link across to asm-xen/asm-x86_64. Unless you think more than a handful of lines could be kept as arch-independent code?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.