Re: [Xen-devel] [PATCH] FP fix for x86-64 xenlinux

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 6 Jun 2005, at 09:23, Nakajima, Jun wrote:

> That's better. I'll send another patch. BTW, they are defined like the
> below for x86 xenlinux:
>
> #define read_cr0() \
>         BUG();
> #define write_cr0(x) \
>         BUG();
>
> We need to fix this as well.
Ah. I guess raid6 accesses %cr0 via its own assembly macros. But yes, I 
think defining the above, and read/write_cr4, the same as native is the 
right thing to do. We can then add in extra functionality to the 
emulation as required. I don't think this will mask bugs in the guest 
OS -- accesses to %cr4 currently aren;t emulated anyway so they will 
crash just as they do today. I may tighten up emulation of %cr0 a bit 
so toggling of unexpected bits at least causes a DPRINTK.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel