[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] FP fix for x86-64 xenlinux


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
  • Date: Mon, 6 Jun 2005 01:23:08 -0700
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 06 Jun 2005 08:22:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcVqcAynV2Ra6gWVTvqBZK4KVs+yfwAAErUA
  • Thread-topic: [Xen-devel] [PATCH] FP fix for x86-64 xenlinux

Keir Fraser wrote:
> On 6 Jun 2005, at 08:02, Nakajima, Jun wrote:
> 
>>> With this patch, # of testcase failures with LTP is < 5 (out of
>>> 800), almost same results as the native x86-64 Linux. The other two
>>> patches for LTP are coming soon; with these, all the testcases will
>>> pass (except the ones that fail on the native x86-64 Linux).
> 
> Consider defining read/write_cr0 macros same as we do in
> arch/xen/i386. We set them the same as native (i.e., real accesses to
> %cr0) and then emulate in Xen. This will ensure that things like
> raid6 will work, which save/restore %cr0 as part of their fpu
> save/restore code. 
> 
>   -- Keir

That's better. I'll send another patch. BTW, they are defined like the
below for x86 xenlinux:

#define read_cr0() \
        BUG();
#define write_cr0(x) \
        BUG();

We need to fix this as well. 

Jun
---
Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.