[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] replace tabs with spaces of Python code

  • To: "aq" <aquynh@xxxxxxxxx>
  • From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
  • Date: Thu, 19 May 2005 02:28:32 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 19 May 2005 01:28:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcVcD2WwDeaTXVswSpuN9BpRnd/fJAAAe6pA
  • Thread-topic: [Xen-devel] [PATCH] replace tabs with spaces of Python code

> actually, i did this job manually, with little help from one 
> small script. the reasons are:
> - as you said, it is very dangeurous to do this kind of thing 
> automatically, so it is best to do it by hand

No, I think I'd rather it was done automatically, by a script that
interprets white space the same way that python does. 
The script from python.org that Anthony posted seems to fit the bill.

It would be very interesting to compare the output of the script against
your patch, to find out whether you fixed any bugs (or introduced any

> Ian, it is a mistake if you dont get this patch. besides, the 
> patch is rather small, and you can check to see if it is OK.

I agree that getting rid of the tabs is important, but it can happen
after some of the outstanding tools merges get completed. Of course, if
in doing the conversion you find bugs, that's a different matter...


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.