Re: [XENBUS PATCH 4/4] balloon: Report ballooning speed in trace log

[Owen Smith <owen.smith@xxxxxxxxx>]

Reviewed-by: Owen Smith <owen.smith@xxxxxxxxx>

On Wed, Aug 13, 2025 at 1:46 PM Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx> wrote:

Ballooning will constantly spam the xen_platform_log, especially if the
balloon is large.

Reduce the log spamming by reporting balloon function times in the trace
log instead.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
 src/xenbus/balloon.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/xenbus/balloon.c b/src/xenbus/balloon.c
index 029fff5..f041a04 100644
--- a/src/xenbus/balloon.c
+++ b/src/xenbus/balloon.c
@@ -299,7 +299,7 @@ done:
     Rate = (ULONGLONG)(Count * 1000) / TimeDelta;
     *Slow = (Rate < XENBUS_BALLOON_MIN_PAGES_PER_S) ? TRUE : FALSE;

-    Info("%u page(s) at %llu pages/s\n", Count, Rate);
+    Trace("%u page(s) at %llu pages/s\n", Count, Rate);
     return Count;
 }

@@ -362,7 +362,7 @@ BalloonPopulatePfnArray(

     Rate = (ULONGLONG)(Count * 1000) / TimeDelta;

-    Info("%u page(s) at %llu pages/s\n", Count, Rate);
+    Trace("%u page(s) at %llu pages/s\n", Count, Rate);
     return Count;
 }

@@ -428,7 +428,7 @@ done:

     Rate = (ULONGLONG)(Count * 1000) / TimeDelta;

-    Info("%u page(s) at %llu pages/s\n", Count, Rate);
+    Trace("%u page(s) at %llu pages/s\n", Count, Rate);
     return Count;
 }

@@ -469,7 +469,7 @@ done:

     Rate = (ULONGLONG)(Count * 1000) / TimeDelta;

-    Info("%u page(s) at %llu pages/s\n", Count, Rate);
+    Trace("%u page(s) at %llu pages/s\n", Count, Rate);
     return Count;
 }

--
2.50.1.windows.1



Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech