WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

[XenPPC] [xenppc-unstable] [POWERPC][XEN][TOOLS] Fix a couple of typos

To: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Subject: [XenPPC] [xenppc-unstable] [POWERPC][XEN][TOOLS] Fix a couple of typos
From: Xen patchbot-xenppc-unstable <patchbot-xenppc-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 29 Aug 2006 11:10:40 +0000
Delivery-date: Tue, 29 Aug 2006 04:24:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
# Node ID 03b9714ea388fa82a3f1344ae8888ce67b1b6ef1
# Parent  5d02e1740961aa13099c3f0f23d9df13223f8456
[POWERPC][XEN][TOOLS] Fix a couple of typos

While getting xend/domU up and runngin today I noticed what
look like a couple of typos.

AFAICT do_dom0_op will return 0 or -1, so the failure test in
tools/libxc/powerpc64/xc_memory.c has the wrong operator.

Also in xen/arch/powerpc/shadow.c:shadow_set_allocation() rc is unused
and thus returning stack garbage.

Signed-off-by: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
---
 tools/libxc/powerpc64/xc_memory.c |    2 +-
 xen/arch/powerpc/shadow.c         |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff -r 5d02e1740961 -r 03b9714ea388 tools/libxc/powerpc64/xc_memory.c
--- a/tools/libxc/powerpc64/xc_memory.c Tue Aug 29 06:53:58 2006 -0400
+++ b/tools/libxc/powerpc64/xc_memory.c Tue Aug 29 07:07:10 2006 -0400
@@ -35,7 +35,7 @@ int xc_alloc_real_mode_area(int xc_handl
 
     err = do_dom0_op(xc_handle, &op);
 
-    if (err > 0)
+    if (err < 0)
         DPRINTF("Failed real mode area allocation for dom %u (log %u)\n",
                 domain, log);
 
diff -r 5d02e1740961 -r 03b9714ea388 xen/arch/powerpc/shadow.c
--- a/xen/arch/powerpc/shadow.c Tue Aug 29 06:53:58 2006 -0400
+++ b/xen/arch/powerpc/shadow.c Tue Aug 29 07:07:10 2006 -0400
@@ -79,7 +79,6 @@ unsigned int shadow_set_allocation(struc
                                     unsigned int megabytes,
                                     int *preempted)
 {
-    unsigned int rc;
     uint pages;
     uint p;
     uint order;
@@ -113,7 +112,7 @@ unsigned int shadow_set_allocation(struc
     for (p = 0; p < (1 << order); p++)
         clear_page((void *)(addr + (p << PAGE_SHIFT)));
 
-    return rc;
+    return 0;
 }
 
 int shadow_control_op(struct domain *d, 

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [XenPPC] [xenppc-unstable] [POWERPC][XEN][TOOLS] Fix a couple of typos, Xen patchbot-xenppc-unstable <=