# HG changeset patch
# User Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
# Node ID 5d02e1740961aa13099c3f0f23d9df13223f8456
# Parent f05a3e9d3e8f67a47afe4f528084d87c2e9d07ce
[XEN][POWERPC] cleanup for (;;);
When the port first started, we didn't even have panic() working
properly so we used "for(;;);" loops to stop execution. Now that output
is buffered these look like hangs, since you usually do not see the
printk() before.
Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
---
xen/arch/powerpc/dart_u3.c | 8 ++++----
xen/arch/powerpc/external.c | 3 +--
xen/arch/powerpc/papr/tce.c | 6 +++---
3 files changed, 8 insertions(+), 9 deletions(-)
diff -r f05a3e9d3e8f -r 5d02e1740961 xen/arch/powerpc/dart_u3.c
--- a/xen/arch/powerpc/dart_u3.c Mon Aug 28 18:35:29 2006 -0500
+++ b/xen/arch/powerpc/dart_u3.c Tue Aug 29 06:53:58 2006 -0400
@@ -55,10 +55,10 @@ static void u3_inv_all(void)
dc.reg.dc_invtlb = 1;
out_32(dart_ctl_reg, dc.dc_word);
- do {
- dc.dc_word = in_32(dart_ctl_reg);
- r++;
- } while ((dc.reg.dc_invtlb == 1) && (r < (1 << l)));
+ do {
+ dc.dc_word = in_32(dart_ctl_reg);
+ r++;
+ } while ((dc.reg.dc_invtlb == 1) && (r < (1 << l)));
if (r == (1 << l)) {
if (l < 4) {
diff -r f05a3e9d3e8f -r 5d02e1740961 xen/arch/powerpc/external.c
--- a/xen/arch/powerpc/external.c Mon Aug 28 18:35:29 2006 -0500
+++ b/xen/arch/powerpc/external.c Tue Aug 29 06:53:58 2006 -0400
@@ -175,8 +175,7 @@ void init_IRQ(void)
void ack_APIC_irq(void)
{
- printk("%s: EOI the whole MPIC?\n", __func__);
- for (;;);
+ panic("%s: EOI the whole MPIC?\n", __func__);
}
void ack_bad_irq(unsigned int irq)
diff -r f05a3e9d3e8f -r 5d02e1740961 xen/arch/powerpc/papr/tce.c
--- a/xen/arch/powerpc/papr/tce.c Mon Aug 28 18:35:29 2006 -0500
+++ b/xen/arch/powerpc/papr/tce.c Tue Aug 29 06:53:58 2006 -0400
@@ -47,7 +47,7 @@ static void h_put_tce(struct cpu_user_re
regs->gprs[3] = H_Success;
}
}
-
+
static void h_get_tce(struct cpu_user_regs *regs)
{
u32 liobn = regs->gprs[4];
@@ -57,7 +57,7 @@ static void h_get_tce(struct cpu_user_re
printk("%s: liobn: 0x%x ioba: 0x%lx \n", __func__, liobn, ioba);
#endif
regs->gprs[3] = H_Function;
- for(;;) ;
+ BUG();
}
static void h_stuff_tce(struct cpu_user_regs *regs)
@@ -76,7 +76,7 @@ static void h_stuff_tce(struct cpu_user_
count);
#endif
regs->gprs[3] = H_Function;
- for(;;);
+ BUG();
}
__init_papr_hcall(H_PUT_TCE, h_put_tce);
_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel
|
Home