| |
|
 |
|
 |
|
|
|
| |
|
|
xen-ppc-devel
Re: [XenPPC] [pushed] [ppc] serial port discovery and zilog device drive
Hollis Blanchard wrote:
On Thu, 2006-05-25 at 17:20 -0400, Maria Butrico wrote:
BTW, I posted various versions of this patch as I was working on it
and I did not hear from you.
Please reread this mail, in which I described the init sequence I would
like to see:
From:
Hollis Blanchard
<hollisb@xxxxxxxxxx>
To:
Maria Butrico
<butrico@xxxxxxxxxxxxxx>
Cc:
xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Subject:
Re: [XenPPC] [Patch] Find serial
device and platform type
Date:
Mon, 24 Apr 2006 11:37:09 -0500
I wasn't sure why you continued to send patches that didn't take my
suggestions into account. Usually the way that works is that either a)
you accept the suggestion, and it is present in the next patch you send,
or b) you disagree with the suggestion, in which case we discuss.
Since there was no discussion, I assumed you accepted the suggestions
but hadn't yet implemented them.
I re-read the email and I think I adopted your suggestions. Some are in
the last patch I sent and some in the one that was committed. What I
did not do is to invoke the serial port initialization code from the
platform specific initialization. I think a broader discussion is
merited on this, and the other issue you raised elsewhere regarding
simple vs canonical probes. I do not think it is useful to hold this
discussion as a consequence of a patch.
Between the serial port detection and the platform detection patch there
was a change, that is, we thought we could delay the platform detection
and do it against the OFD tree. In retrospect, that would have been too
late. Since we now do the platform detection earlier (from boot_of.c),
then we could probably switch the serial port initialization there too.
Unfortunately the detection of the serial port and the identification of
its address does not change much one way or another.
Beside Jimi, Hollis and myself, who else is interested in this issue and
wants to participate in a meeting to discuss this?
_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel
|
|
|
| |
|
Home