This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-ia64-devel] Re: [PATCH] [ia64] kexec: Use error path if crash regio

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: [Xen-ia64-devel] Re: [PATCH] [ia64] kexec: Use error path if crash region range can't be accessed
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Tue, 26 Feb 2008 11:29:07 -0700
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 26 Feb 2008 10:29:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080226045714.463EC4F937@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: HP OSLO R&D
References: <20080226045714.463EC4F937@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2008-02-26 at 13:56 +0900, Simon Horman wrote:
> Although the error handling path in xen_machine_kexec_setup_resource() is
> somewhat minmal, it ought to be used if HYPERVISOR_kexec_op() fails when
> getting the crash kernel region, as this indicates that an error occured,
> not that the crash kernel region is empty.

> --- 
> Alex: This is a fairly trivial fix, please consider merging independantly
>       of other kexec patches

Hi Simon,

   I agree, this looks trivial, but it's common code.  Shouldn't this go
through xen-devel?  Thanks,


Alex Williamson                             HP Open Source & Linux Org.

Xen-ia64-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>