This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-ia64-devel] [PATCH] [ia64] kexec: Use error path if crash region ra

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [PATCH] [ia64] kexec: Use error path if crash region range can't be accessed
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 26 Feb 2008 13:56:10 +0900
Cc: Alex Williamson <alex.williamson@xxxxxx>
Delivery-date: Mon, 25 Feb 2008 20:57:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Although the error handling path in xen_machine_kexec_setup_resource() is
somewhat minmal, it ought to be used if HYPERVISOR_kexec_op() fails when
getting the crash kernel region, as this indicates that an error occured,
not that the crash kernel region is empty.

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Alex: This is a fairly trivial fix, please consider merging independantly
      of other kexec patches
Index: linux-2.6.18-xen.hg/drivers/xen/core/machine_kexec.c
--- linux-2.6.18-xen.hg.orig/drivers/xen/core/machine_kexec.c   2008-02-25 
14:18:40.000000000 +0900
+++ linux-2.6.18-xen.hg/drivers/xen/core/machine_kexec.c        2008-02-25 
14:19:00.000000000 +0900
@@ -85,7 +85,7 @@ void __init xen_machine_kexec_setup_reso
        range.range = KEXEC_RANGE_MA_CRASH;
        if (HYPERVISOR_kexec_op(KEXEC_CMD_kexec_get_range, &range))
-               return;
+               goto err;
        if (range.size) {
                crashk_res.start = range.start;

Xen-ia64-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>