WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] PATCH: mini-cleanup in vtlb.c

To: tgingold@xxxxxxx, Xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxx>
Subject: Re: [Xen-ia64-devel] PATCH: mini-cleanup in vtlb.c
From: Tristan Gingold <tgingold@xxxxxxx>
Date: Mon, 17 Sep 2007 04:53:57 +0200
Delivery-date: Sun, 16 Sep 2007 19:48:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070916044056.GA18952@xxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070916030422.GA5474@xxxxxxxxxxxxxxxxxxxxx> <20070916044056.GA18952@xxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Sun, Sep 16, 2007 at 12:40:56AM -0400, Aron Griffis wrote:
> Hi Tristan,
> 
> tgingold@xxxxxxx wrote:  [Sat Sep 15 2007, 11:04:22PM EDT]
> > -    rid = rid&RR_RID_MASK;;
> > +    rid = rid & RR_RID_MASK;;
> 
> This appears twice in the cleanup, verbatim...  Couldn't it just be
> rid &= RR_RID_MASK?  Also, why the double-semicolon?  I don't think
> that means anything in C.
Yes, yes I saw this after mailing the patch!  Will be fixed in my next
cleanup.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>