Re: [Xen-ia64-devel] Protection key support for PV domains

[tgingold@xxxxxxx]

Quoting Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxxxxxxx>:

> Hi Tristan,
>
> I have still a question:
>
> Am Freitag, 13. Juli 2007 schrieb Tristan Gingold:
> > > + * cache.
> > > + */
> > > +static inline void
> > > +ia64_itc_PKR (__u64 target_mask, __u64 vmaddr, __u64 pte,
> > > +                                         __u64 log_page_size, __u64 key)
> >
> > If log_page_size and key are merged into itir, no need to define this
> > function.
>
> The current used linux function is:
> static inline void
> ia64_itc (__u64 target_mask, __u64 vmaddr, __u64 pte,
>           __u64 log_page_size)
> {
>         ia64_setreg(_IA64_REG_CR_ITIR, (log_page_size << 2));
> ...
> If I use ia64_itc() I would have to do a hack to prepare a special itir to
> fit
> key + ps into log_page_size the right way.
> itir = (IA64_ITIR_PS_KEY(logps, key) >> 2)
> This was the reason to expand the linux function.
> OK I can do this with a big comment but it's not fine.

You should rename log_page_size into itir and fix all caller.  This is the
right way to do this IMHO.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel