WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] PATCH: rewrite vcpu_get_psr

To: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Subject: RE: [Xen-ia64-devel] PATCH: rewrite vcpu_get_psr
From: tgingold@xxxxxxx
Date: Fri, 11 May 2007 10:18:12 +0200
Cc: Xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 11 May 2007 01:16:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <51CFAB8CB6883745AE7B93B3E084EBE2B53D46@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <51CFAB8CB6883745AE7B93B3E084EBE2B53D46@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Internet Messaging Program (IMP) 3.2.5
Quoting "Xu, Anthony" <anthony.xu@xxxxxxxxx>:

> >Tristan Gingold
> >Sent: 2007Äê5ÔÂ11ÈÕ 13:23
> >To: Alex Williamson
> >Cc: Xen-ia64-devel
> >Subject: Re: [Xen-ia64-devel] PATCH: rewrite vcpu_get_psr
> >
> >> Unfortunately...
> >It's a little bit puzzling.  I didn't think the performace of mov =psr.l was
> >to important!
>
>
>
> +
> +     if (!PSCB(vcpu, metaphysical_mode))
> +             newpsr.i64 |= IA64_PSR_DT | IA64_PSR_RT | IA64_PSR_IT;
>
> -     if (PSCB(vcpu, metaphysical_mode))
> -             newpsr.dt = 0;
>
> Above old code would be translated to
>       if (PSCB(vcpu, metaphysical_mode))
>               newpsr.i64 &= ~IA64_PSR_DT;
I seriously think the old code was wrong (more precisely incorrect).

I have to re-read Dan's paper and linux code, but in PV mode we only correctly
support IT=DT=RT.

(the same should be true for VTi BTW and incidently we can
easily write OS which cannot be virtualized by VTi!)

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel