This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [PATCH] Re: [Xen-devel] Re: [PATCH 2/2] PV framebuffer

To: Markus Armbruster <armbru@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Re: [Xen-devel] Re: [PATCH 2/2] PV framebuffer
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 14 Dec 2006 13:30:46 +0000
Cc: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 14 Dec 2006 05:30:47 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <87ejr21wmy.fsf@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccfhA+HTdf0uYt3Edu2MgAX8io7RQ==
Thread-topic: [PATCH] Re: [Xen-devel] Re: [PATCH 2/2] PV framebuffer
User-agent: Microsoft-Entourage/
On 14/12/06 12:37, "Markus Armbruster" <armbru@xxxxxxxxxx> wrote:

>> The lock is used in fb_ops, vm_ops and kthread contexts. None of these are
>> executed in IRQ context so irqsave is not needed. I'll remove it. I'm not
>> sure whether you can call zap_page_range() even with a spinlock held
>> though...
>>  -- Keir
> You can't.  This was spotted just yesterday in our internal review.
> I'm working on a fix.  If you could hold the removal of irqsave for a
> bit, that would avoid merge conflicts.

Too late I'm afraid.

If you come up with a reasonable fix before 3.0.4 goes out it'd be nice to
slip a fix in if it's not too big.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>