Re: [Xen-ia64-devel] [patch 1/5] sn2+machvec support

[Jes Sorensen <jes@xxxxxxx>]

Alex Williamson wrote:
> Hi Jes,
> 
>    Thanks for the cleanup.  I've added most of these to the mercurial
> tree here:
> 
> http://free.linux.hp.com/~awilliam/xen-ia64-machvec/
> 
> I found a couple more README.origin files that needed updating and
> reworked parts of patch 4 (adding lots more #ifdef XEN where code was
> simply added or removed before).  Overall, it looks pretty good.  The
> things not in this tree are the updates to sn_sal.h and list.h.
>
>    The sn_sal.h in the patch looked like a mix of various upstream
> versions of the file.  I re-based sn_sal.h in the tree above to 2.6.19,
> please re-implement the Xen fixes against that version.

Thats why I didn't add sn_sal.h to the README.origin since it was
unclear where it came from and I just added the bits I needed. Syncing
it to 2.6.19 should be ok though.

>    The Xen list.h doesn't seem to cleanly match any upstream Linux base,
> which makes me suspicious that it's had functionality intentionally
> pruned out of it.  Did you figure out what it's currently based on?  I'm
> wondering if we should try to only include the subset of functionality
> we need rather than move the whole file forward.  It's probably worth a
> discussion on xen-devel to make sure we don't get any surprises when we
> try to merge it upstream.  Thanks,

list.h is strange issue. It was clearly taken from Linux, prior to the
klist support being added, but nobody bothered to mark why they took
which bits and left out other bits. Figuring that part out is impossible
unless the original author will admit what he did. Given that list.h is
solely macros  and inlines, it shouldn't be an issue to add it to the
main thing.

I would prefer we simply add my changes and go from there, but we can
also try and resync it completely to the Linux version and fix that up.
The main problem is that the Linux version provides RCU versions of a
lot of list functions, but Xen doesn't have RCU support .... yet (but
that is a totally different discussion we have to look into later).

Cheers,
Jes

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel