This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-ia64-devel] Reserved Register/Field fault not correct handledin

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] Reserved Register/Field fault not correct handledin Xen?
From: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 12 Dec 2006 16:01:30 +0100
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 12 Dec 2006 07:01:26 -0800
Domainkey-signature: s=s768; d=fujitsu-siemens.com; c=nofws; q=dns; b=pWUPAiWVcMwvW68xZHosiiJRdUyERz0m9WC8l93uerl4QxU/Wvae6UsjQuL5nkdoO33ROA91p3L34UXZQtp+d9Bgr60+hSajFxBcGjFez9QTE3NxlXhjqYugud7v0rS3;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E6C71DE9CDD4A8takebe_akio@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200612121204.03472.dietmar.hahn@xxxxxxxxxxxxxxxxxxx> <E6C71DE9CDD4A8takebe_akio@xxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.5
Hi Akio,

> I think your suggestion is almost right.
> But should the folloing IA64_ISR_CODE_LFETCH be checked?
> (because Privilege Register Fault may be occurred on guest.)
> ia64_fault()
>  393         if ((isr & IA64_ISR_NA) &&
>  394             ((isr & IA64_ISR_CODE_MASK) == IA64_ISR_CODE_LFETCH)) {
>  395                 /*
>  396                  * This fault was due to lfetch.fault, set "ed" bit in
> the 397                  * psr to cancel the lfetch.
>  398                  */
>  399                 ia64_psr(regs)->ed = 1;
>  400                 printk("ia64_fault: handled lfetch.fault\n");
>  401                 return;
>  402         }

If the FAULT_OR_REFLECT(24) is called in the trap handler, than the domU has 
to handle the lfetch.fault. and this is OK, I think.
So my suggestion should be OK?

> Could you send patches?
Yes I'll prepare and send a patch.


Xen-ia64-devel mailing list