RE: [Xen-ia64-devel] [PATCH] [RESEND] domU destroy & page ref counter

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Masaki Kanno
>Sent: 2006年3月10日 9:38
>Hi,
>
>We resend these patches. We made these patches to the latest
>changeset:9161,
>and reflected comments.
>We tested the creation and the destruction of domU repeatedly 100 times.
>As a result, there was not the memory which was not freed in xen/ia64.
>Please apply these patches to the xen-ia64-unstable tree.
>
>Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
>Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>
>Best regards,
> Kan, and Fujitsu team

Hi, Kan and Akio,
        Good work to see it in tree now. Now several minor comments :-)

For refcount:
- You may want to change PGT_va_shift to 32 like x86-64 since "unsigned 
long type_info" is 64bit width on IA64. Or you either can define it as "u32 
type_info" to save space since higher half is not used by your patch.

For domain destroy:
- Also need to free metaphysical rid, which is null by far. Current 
metaphysical rid allocation policy is monotonic-incremental-allocation-no-free
 style. Though it's unlikely to see exhaust of this area (one block reserved by
 far), it's better to change it to a cleaner, more efficient policy. You may at 
least put a call there if delayed with lower priority.

- Maybe you can use xenpage_list to track p2m pages instead of adding a 
new pg_list and BUG_ON for the former?

More to consider for future of inter-domain reference:
        I haven't looked into Isaku's p2m implementation yet. However when 
dom0 is converted without p==m, foreign page map will also trap into 
Xen for inc/dec refcount of foreign pages. You may co-work with Isaku to 
see whether similar issue can be addressed.

Thanks,
Kevin


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel