WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] "-Wall" option doesn't work

To: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>, "Xu, Anthony" <anthony.xu@xxxxxxxxx>, <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] "-Wall" option doesn't work
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Wed, 25 Jan 2006 10:40:37 +0100
Delivery-date: Wed, 25 Jan 2006 08:45:52 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <516F50407E01324991DD6D07B0531AD59035AD@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <516F50407E01324991DD6D07B0531AD59035AD@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Jeudi 19 Janvier 2006 23:06, Magenheimer, Dan (HP Labs Fort Collins) a 
écrit :
> > The first one was very big (140KB) and Dan rejected it almost
> > for this reason.
> >
> > The second one was rather small (4KB) and fixed the most
> > boring warnings (the
> > most obvious and those in .h files which appear in every
> > file). It was not
> > accepted (without explaination).
> >
> > I am not sure Dan is interested in warnings.
>
> I forgot to discuss this at the summit.   Kevin is correct that I
> didn't accept the large 140KB patch because it changed so many
> files, including many linux and linux-xen files, at a time when
> the tree was not very stable.  I do agree that removing warnings
> is a good idea as they often hide real bugs.  However sometimes
> fixing them requires changes that might introduce new bugs.
>
> I had intended to commit the smaller patch some time ago, but
> forgot.   I committed it after Tristan resubmitted it.
>
> Now that -Wall is on and the tree is fairly stable, it might
> be a good time to fix more warnings, especially in the xen
> and vmx directories.  I would like to hold patches that fix
> warnings in the arch/ia64/linux and arch/ia64/linux-xen directories
> until we rebase to 2.6.15.
Thank you.
This is clear and makes sense.

Tristan.



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>