This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-ia64-devel] [PATCH] This is the first patch to merge vcpu.c

To: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Subject: RE: [Xen-ia64-devel] [PATCH] This is the first patch to merge vcpu.c
From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Date: Tue, 13 Sep 2005 21:48:24 -0700
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 14 Sep 2005 04:49:11 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcW3k8hGa6d5du+US6qlqScOINw+uABUwSAg
Thread-topic: [Xen-ia64-devel] [PATCH] This is the first patch to merge vcpu.c
Hi Anthony --

I tried your patch.  It applies cleanly and compiles
cleanly.  However, I am seeing problems when testing it.
I run a script that builds linux ten times as
a stress test.  During this test, twice, gcc has
frozen or gotten into an infinite loop; I'm not
really sure other than it continues to eat up CPU
time and not make forward progress.  Other times
building linux completes OK.

Have you stress-tested the patch on your system?
I would be curious whether you can reproduce it.
I can send you my buildlinux script if you like.


> -----Original Message-----
> From: Xu, Anthony [mailto:anthony.xu@xxxxxxxxx] 
> Sent: Monday, September 12, 2005 6:28 AM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-ia64-devel] [PATCH] This is the first patch to 
> merge vcpu.c
> Dan,
> This patch is based on ver 6723. And definitely I can boot 
> dom0 with this patch.
> Following things are done in this patch.
> 1. Merge structure pt_reg.
> 2. Though vcpu_info structure has been merged, non-vt domain 
> used pointer vcpu->vcpu_info->arch.privregs, and vt domain 
> used pointer vcpu->arch.arch_vmx.vpd, the value of these two 
> pointers are different, that means vt and non-vt domain still 
> use different privileged registers pages, in this case, we 
> can't merge vcpu.c, so I merged these two pointer, and put it 
> at vcpu->arch.privregs. vcpu->vcpu_info->arch.privregs and 
> vcpu->arch.arch_vmx.vpd  will not exist. Why put it at 
> vcpu->arch.privregs?  1. There will be one less pointer 
> unreferenced when accessing this privileged registers page. 
> 2. vcpu->vcpu_info can be accessed by guest, but guest can't 
> access privileged registers page through this address, guest 
> can access this privileged page only through another special 
> mapping. So there is no need to expose this pointer to guest 
> by putting it in vcpu->vcpu_info structure. All accesses to 
> this page is through VCPU(vcpu,y) macro,
> 3. Merged following functions.
>       Vcpu_set/get_(interruption control registers from cr16 
> to cr25), corresponding functions vmx_vcpu_set/get_*** will not exist.
>       Vcpu->arch.arch_vmx.in_service[4] will not exist, we 
> will all use vcpu->arch.insvc[4]
> 4. Cleaned up some unused structure members and codes.
> Signed-off-by Anthony Xu <Anthony.xu@xxxxxxxxx>
> Thanks,
> Anthony

Xen-ia64-devel mailing list