WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] RE: [PATCH] Patch to make latest hg multi-domainbac

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx>
Subject: RE: [Xen-ia64-devel] RE: [PATCH] Patch to make latest hg multi-domainback to work
From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Date: Thu, 8 Sep 2005 05:49:58 -0700
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 08 Sep 2005 12:47:29 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcWvySFLppJ+ILkHRKOQH/MX6thvfgEH6v3wABtDOHAAAcMDgAAFlokw
Thread-topic: [Xen-ia64-devel] RE: [PATCH] Patch to make latest hg multi-domainback to work
>       Could you elaborate more how your latest patch works 
> differently and fix the potential issue?
> 
> -               *pteval = vcpu->arch.dtlb_pte;
> +               if (vcpu->domain==dom0 && !in_tpa) *pteval = 
> trp->page_flags;
> +               else *pteval = vcpu->arch.dtlb_pte;
> +               printf("DTLB MATCH... NEW, DOM%s, %s\n", 
> vcpu->domain==dom0?
> +                       "0":"U", 
> in_tpa?"vcpu_tpa":"ia64_do_page_fault");
> 
>       The new limitation seems only for dom0, while dom0 has 
> exactly same guest physical address as machine address. Based 
> upon this assumption, trp->page_flags actually equals to 
> guest pte (vcpu->arch.dtlb_pte)? So I'm not sure about the 
> trick here behind.

I don't understand myself why the fix works, which is why
I didn't propose it as a "final" patch.  In tracking down
the crash, I added printfs to see when it happened and
found that it only occurred in domain0 when vcpu_translate
was called from vcpu_tpa and so tried the above workaround
and it eliminated the crash.

I didn't have time at that point to study why the fix worked,
so just posted the workaround in case others were having
problems with the crash.

I agree that the fix doesn't seem like it should work.  There's
something else strange going on (cue music from Twilight
Zone here).

Dan

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel